Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

khepri_cluster: Add is_store_running/1 helper #175

Merged
merged 1 commit into from
Dec 7, 2022

Conversation

dumbbell
Copy link
Member

@dumbbell dumbbell commented Dec 7, 2022

The function verifies that:

  1. the local Ra server is running
  2. the store ID is known by the local instance of the application

@dumbbell dumbbell added the enhancement New feature or request label Dec 7, 2022
@dumbbell dumbbell added this to the v0.7.0 milestone Dec 7, 2022
@dumbbell dumbbell self-assigned this Dec 7, 2022
@codecov
Copy link

codecov bot commented Dec 7, 2022

Codecov Report

Base: 90.82% // Head: 90.79% // Decreases project coverage by -0.03% ⚠️

Coverage data is based on head (4987dfd) compared to base (38f07ec).
Patch coverage: 90.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #175      +/-   ##
==========================================
- Coverage   90.82%   90.79%   -0.04%     
==========================================
  Files          19       19              
  Lines        3378     3388      +10     
==========================================
+ Hits         3068     3076       +8     
- Misses        310      312       +2     
Flag Coverage Δ
erlang-24 89.49% <90.00%> (+<0.01%) ⬆️
erlang-25 89.63% <90.00%> (-0.09%) ⬇️
os-ubuntu-latest 90.67% <90.00%> (-0.10%) ⬇️
os-windows-latest 89.63% <90.00%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/khepri_cluster.erl 80.69% <90.00%> (+0.30%) ⬆️
src/khepri_machine.erl 94.67% <0.00%> (-0.14%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

The function verifies that:
1. the local Ra server is running
2. the store ID is known by the local instance of the application
@dumbbell dumbbell marked this pull request as ready for review December 7, 2022 17:22
@dumbbell dumbbell merged commit 38e2fae into main Dec 7, 2022
@dumbbell dumbbell deleted the add-is_store_running-api branch December 7, 2022 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant