projections: Delete tree nodes recursively #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 90.86% // Head: 90.82% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #178 +/- ##
==========================================
- Coverage 90.86% 90.82% -0.04%
==========================================
Files 19 19
Lines 3427 3446 +19
==========================================
+ Hits 3114 3130 +16
- Misses 313 316 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
dcorbacho
approved these changes
Jan 11, 2023
dumbbell
reviewed
Jan 11, 2023
the-mikedavis
force-pushed
the
md-recursive-delete-projection
branch
from
15d0c1f
to
d2c4d0c
Compare
the-mikedavis
changed the title
the-mikedavis
force-pushed
the
md-recursive-delete-projection
branch
from
d2c4d0c
to
11dd9d4
Compare
the-mikedavis
force-pushed
the
md-recursive-delete-projection
branch
from
11dd9d4
to
01d1372
Compare
the-mikedavis
force-pushed
the
md-recursive-delete-projection
branch
from
01d1372
to
6d6d9f2
Compare
dumbbell
approved these changes
Feb 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A deletion to a tree node with children also recursively deletes all of the children tree nodes. Previously, deleted children tree nodes were not deleted from projections. This change looks for all children tree nodes of a deleted tree node and issues projection trigger effects for each deleted tree node.