Move insert_or_update_node/5 from khepri_machine to khepri_tree #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change completes the migration started in 2ebf1cc which moved functions that acted on the tree structure from 'khepri_machine' to 'khepri_tree'. With this change, the tree structure can be created and modified without interacting with the machine state. The implementation of 'insert_or_update_node/5' is extracted to 'khepri_tree' without changes except that the creation of side-effects and the reorganizing of the return value now live separately in 'khepri_machine'. This also allows us to remove a few function exports from 'khepri_tree' which were either being called by 'insert_or_update_node/5' or were only used internally to 'khepri_tree'.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #187 +/- ##
==========================================
+ Coverage 90.95% 91.07% +0.11%
==========================================
Files 20 20
Lines 3495 3494 -1
==========================================
+ Hits 3179 3182 +3
+ Misses 316 312 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
dumbbell
approved these changes
Mar 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change completes the migration started in #184 which moved functions that acted on the tree structure from
khepri_machinetokhepri_tree. With this change, the tree structure can be created and modified without interacting with the machine state. The implementation ofinsert_or_update_node/5is extracted tokhepri_treewithout changes except that the creation of side-effects and the reorganizing of the return value now live separately inkhepri_machine.This also allows us to remove a few function exports from
khepri_treewhich were either being called byinsert_or_update_node/5or were only used internally tokhepri_tree.