projections: Trigger changes for leaf node deletions #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change fixes a regression introduced with the refactor to the pattern tree to hold projections for a specific case of deletions from the tree tree. To hit this edge-case, a path must be deleted from the tree with no other sibling tree nodes. In other words, the deletion must not trigger any ancestor tree nodes from being cleaned up by the default keep-while conditions. Also, a projection must be registered to a path pattern which would match this deleted path. For deletion changes, we look at all of the children of the deleted path to check if child node deletions should trigger any projections. This block mistakenly forgot to also check if the deleted path itself should trigger any projections.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #193 +/- ##
==========================================
- Coverage 91.07% 91.04% -0.03%
==========================================
Files 21 21
Lines 3541 3541
==========================================
- Hits 3225 3224 -1
- Misses 316 317 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
dumbbell
approved these changes
Mar 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes a regression introduced with the refactor to the pattern tree to hold projections for a specific case of deletions from the tree tree.
To hit this edge-case, a path must be deleted from the tree with no other sibling tree nodes. In other words, the deletion must not trigger any ancestor tree nodes from being cleaned up by the default keep-while conditions. Also, a projection must be registered to a path pattern which would match this deleted path.
For deletion changes, we look at all of the children of the deleted path to check if child node deletions should trigger any projections. This block mistakenly forgot to also check if the deleted path itself should trigger any projections.