Special-case trivial "copy"-style projections #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A common case for projection functions is to re-use each tree node's
payload as the record for the projection ETS table. In terms of a
simple projection, this is:
fun(_Path, Payload) -> Payload end
This change allows passing a special 'copy' atom to stand for this
case. When triggering a projection we don't execute a Horus function
so 'copy' projections have minimal overhead.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #204 +/- ##
=======================================
Coverage 88.67% 88.67%
=======================================
Files 20 20
Lines 2781 2790 +9
=======================================
+ Hits 2466 2474 +8
- Misses 315 316 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
dumbbell
approved these changes
May 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A common case for projection functions is to re-use each tree node's payload as the record for the projection ETS table. In terms of a simple projection, this is:
This change allows passing a special 'copy' atom to stand for this case. When triggering a projection we don't execute a Horus function so 'copy' projections have minimal overhead.