Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove debug logs for successful query of members #208

Merged
merged 1 commit into from
May 30, 2023
Merged

Conversation

dcorbacho
Copy link
Contributor

It just floods the logs on any long run. Just leave the failure ones.

It just floods the logs on any long run. Just leave the failure ones.
@dcorbacho dcorbacho requested a review from dumbbell May 26, 2023 10:22
@codecov
Copy link

codecov bot commented May 26, 2023

Codecov Report

Patch coverage has no change and project coverage change: +1.34 🎉

Comparison is base (90efd62) 90.96% compared to head (afbbffa) 92.31%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #208      +/-   ##
==========================================
+ Coverage   90.96%   92.31%   +1.34%     
==========================================
  Files          16       21       +5     
  Lines        2868     4917    +2049     
==========================================
+ Hits         2609     4539    +1930     
- Misses        259      378     +119     
Flag Coverage Δ
erlang-24 91.33% <ø> (+1.62%) ⬆️
erlang-25 91.31% <ø> (+1.81%) ⬆️
erlang-26 88.85% <ø> (?)
os-ubuntu-latest 92.23% <ø> (+1.33%) ⬆️
os-windows-latest 91.25% <ø> (+1.74%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/khepri_cluster.erl 80.88% <ø> (+0.68%) ⬆️

... and 16 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dumbbell
Copy link
Member

Because it is not a cheap call, I wanted to keep them around until we have something lighter to query cluster members. What do you think? I say that, but I don't have an implementation idea yet.

@dcorbacho
Copy link
Contributor Author

If you have any use for the logs, just leave them. But the issue I have is not with the query itself, but the huge logs it generates where this repeated line just becomes noise. It needs to be filtered out every time to find the relevant information on the logs.

@dumbbell dumbbell merged commit 9d95d5d into main May 30, 2023
9 checks passed
@dumbbell dumbbell deleted the reduce-debug-log branch May 30, 2023 08:19
@dumbbell
Copy link
Member

Ok, if it's painful, let's remove them. I will take note that RabbitMQ calls this way too often, currently causing delays, and that this must be investigated.

@dumbbell dumbbell added this to the v0.8.0 milestone Jul 26, 2023
@dumbbell dumbbell added the enhancement New feature or request label Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants