projections: Allow passing Horus options #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default Horus options used by `khepri_projection:new/3` prevent unintentional non-determinism or interaction between processes. It could be useful to have an escape hatch for this, though. For example you might want to call `persistent_term:get/2` and `persistent_term:put/2` to create some lazy value to use in the projection function. This change allows passing in `horus:options()` when creating a projection with `khepri_projection:new/2`. These options are merged with the defaults and passed to `horus:to_standalone_fun/2`.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #209 +/- ##
==========================================
+ Coverage 89.31% 89.33% +0.01%
==========================================
Files 20 20
Lines 2799 2803 +4
==========================================
+ Hits 2500 2504 +4
Misses 299 299
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
dumbbell
approved these changes
Jun 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default Horus options used by
khepri_projection:new/3prevent unintentional non-determinism or interaction between processes. It could be useful to have an escape hatch for this, though. For example you might want to callpersistent_term:get/2andpersistent_term:put/2to create some lazy value to use in the projection function.This change allows passing in
horus:options()when creating a projection withkhepri_projection:new/2. These options are merged with the defaults and passed tohorus:to_standalone_fun/2.