khepri_utils: Gracefully handle unavailable default applications #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the Khepri application is started and any of the default applications (mnesia, sasl, ssl, and khepri itself) are not available, `application:get_key/2` will return `undefined`, causing a badmatch that will terminate the Khepri application. Instead we can gracefully handle these applications being unavailable and not include their modules in the list of modules to skip when extracting functions.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #215 +/- ##
==========================================
- Coverage 89.39% 89.33% -0.07%
==========================================
Files 20 20
Lines 2820 2822 +2
==========================================
Hits 2521 2521
- Misses 299 301 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
dumbbell
deleted the
md-khepri_utils-remove-application-modules-assertion
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the Khepri application is started and any of the default applications (mnesia, sasl, ssl, and khepri itself) are not available,
application:get_key/2will returnundefined, causing a badmatch that will terminate the Khepri application. Instead we can gracefully handle these applications being unavailable and not include their modules in the list of modules to skip when extracting functions.Fixes #214