Add a command to unregister projections #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #220 +/- ##
==========================================
- Coverage 89.34% 89.18% -0.16%
==========================================
Files 20 20
Lines 2825 2867 +42
==========================================
+ Hits 2524 2557 +33
- Misses 301 310 +9
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
dumbbell
reviewed
Aug 3, 2023
Projections can be registered but not removed once they're in the store. This change adds functions to remove projections from the store by name, so if we need to alter projections in the future we can call 'unregister_projection' and then register replacements.
the-mikedavis
force-pushed
the
md-unregister-projection
branch
from
ab7c3a8
to
87ae146
Compare
dumbbell
approved these changes
Aug 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Projections can be registered but not removed once they're in the store. This change adds functions to remove projections from the store by name, so if we need to alter projections in the future we can call 'unregister_projection' and then register replacements.
See #213