Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

khepri_machine: Handle {error,shutdown} response from Ra queries #223

Merged
merged 1 commit into from
Aug 18, 2023

Conversation

the-mikedavis
Copy link
Member

Ra's query functions may return {error,shutdown} if the server process receives the query but shuts down before it is able to reply. This is the same as the change in #211 but covers queries.

Ra's query functions may return `{error,shutdown}` if the server process
receives the query but shuts down before it is able to reply. This is
the same as the change in 812bb82 but covers queries.
@the-mikedavis the-mikedavis self-assigned this Aug 16, 2023
@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (cbbe2ba) 89.18% compared to head (ecf1a06) 89.18%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #223   +/-   ##
=======================================
  Coverage   89.18%   89.18%           
=======================================
  Files          20       20           
  Lines        2867     2867           
=======================================
  Hits         2557     2557           
  Misses        310      310           
Flag Coverage Δ
erlang-24 88.17% <ø> (ø)
erlang-25 88.10% <ø> (+0.06%) ⬆️
erlang-26 88.73% <ø> (-0.14%) ⬇️
os-ubuntu-latest 89.04% <ø> (-0.14%) ⬇️
os-windows-latest 88.03% <ø> (+0.24%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/khepri_machine.erl 95.29% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@dumbbell dumbbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@dumbbell dumbbell merged commit 9e46d2c into main Aug 18, 2023
10 checks passed
@dumbbell dumbbell deleted the md-handle-ra-query-shutdown-error branch August 18, 2023 15:35
@dumbbell dumbbell added this to the v0.8.0 milestone Aug 18, 2023
@dumbbell dumbbell added bug Something isn't working enhancement New feature or request and removed bug Something isn't working labels Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants