khepri_machine: Use cached leader for async commands #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Async commands will fail to be applied unless they're sent to the
cluster's current leader. With this change we always try to use the
cached leader from synchronous commands if available and use the local
member if the leader isn't cached. The caller can then update the cached
leader value when the async response says that the command was sent
against a non-leader member, like so:
receive
{ra_event,
FromId,
{rejected, {not_leader, MaybeLeader, CorrelationId}}} ->
ok = khepri_cluster:cache_leader_if_changed(
StoreId, FromId, MaybeLeader),
%% ... retry the command for `CorrelationId' ...
ok
end
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #228 +/- ##
==========================================
+ Coverage 88.85% 88.93% +0.07%
==========================================
Files 20 20
Lines 2890 2891 +1
==========================================
+ Hits 2568 2571 +3
+ Misses 322 320 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
michaelklishin
approved these changes
Oct 5, 2023
dumbbell
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Async commands will fail to be applied unless they're sent to the cluster's current leader. With this change we always try to use the cached leader from synchronous commands if available and use the local member if the leader isn't cached. The caller can then update the cached leader value when the async response says that the command was sent against a non-leader member, like so: