khepri_machine: Use functions to manipulate the internal state #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... instead of using the record directly. [Why] This is a preparation step for a future update of the record. At that point, there will be two versions of the state record to support and it's easier to isolate that handling in a few functions. [How] All reads and writes to the state go through a set of `get_*/1` and `set_*/2` functions.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #253 +/- ##
==========================================
+ Coverage 89.15% 89.34% +0.19%
==========================================
Files 20 20
Lines 2932 2975 +43
==========================================
+ Hits 2614 2658 +44
+ Misses 318 317 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
dumbbell
deleted the
isolate-machine-state-handling-in-dedicated-functions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… instead of using the record directly.
Why
This is a preparation step for a future update of the record. At that point, there will be two versions of the state record to support and it's easier to isolate that handling in a few functions.
How
All reads and writes to the state go through a set of
get_*/1andset_*/2functions.