Correct test variable names

rabbitmq · Mar 9, 2021 · cf023ac · cf023ac
1 parent 3043910
commit cf023ac
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 19 deletions.
diff --git a/api/v1alpha1/binding_types_test.go b/api/v1alpha1/binding_types_test.go
@@ -46,9 +46,9 @@ var _ = Describe("Binding spec", func() {
 	})
 
 	It("creates a binding with configurations", func() {
-		q := Binding{
+		binding := Binding{
 			ObjectMeta: metav1.ObjectMeta{
-				Name:      "random-q",
+				Name:      "random-binding",
 				Namespace: namespace,
 			},
 			Spec: BindingSpec{
@@ -66,11 +66,11 @@ var _ = Describe("Binding spec", func() {
 				},
 			},
 		}
-		Expect(k8sClient.Create(ctx, &q)).To(Succeed())
+		Expect(k8sClient.Create(ctx, &binding)).To(Succeed())
 		fetchedBinding := &Binding{}
 		Expect(k8sClient.Get(ctx, types.NamespacedName{
-			Name:      q.Name,
-			Namespace: q.Namespace,
+			Name:      binding.Name,
+			Namespace: binding.Namespace,
 		}, fetchedBinding)).To(Succeed())
 
 		Expect(fetchedBinding.Spec.Vhost).To(Equal("/avhost"))

diff --git a/api/v1alpha1/exchange_types_test.go b/api/v1alpha1/exchange_types_test.go
@@ -28,7 +28,7 @@ var _ = Describe("Exchange spec", func() {
 			},
 		}
 
-		q := Exchange{
+		exchange := Exchange{
 			ObjectMeta: metav1.ObjectMeta{
 				Name:      "test-exchange",
 				Namespace: namespace,
@@ -41,19 +41,19 @@ var _ = Describe("Exchange spec", func() {
 				},
 			},
 		}
-		Expect(k8sClient.Create(ctx, &q)).To(Succeed())
+		Expect(k8sClient.Create(ctx, &exchange)).To(Succeed())
 		fetchedExchange := &Exchange{}
 		Expect(k8sClient.Get(ctx, types.NamespacedName{
-			Name:      q.Name,
-			Namespace: q.Namespace,
+			Name:      exchange.Name,
+			Namespace: exchange.Namespace,
 		}, fetchedExchange)).To(Succeed())
 		Expect(fetchedExchange.Spec).To(Equal(expectedSpec))
 	})
 
 	It("creates a exchange with configurations", func() {
-		q := Exchange{
+		exchange := Exchange{
 			ObjectMeta: metav1.ObjectMeta{
-				Name:      "random-q",
+				Name:      "random-exchange",
 				Namespace: namespace,
 			},
 			Spec: ExchangeSpec{
@@ -71,11 +71,11 @@ var _ = Describe("Exchange spec", func() {
 				},
 			},
 		}
-		Expect(k8sClient.Create(ctx, &q)).To(Succeed())
+		Expect(k8sClient.Create(ctx, &exchange)).To(Succeed())
 		fetchedExchange := &Exchange{}
 		Expect(k8sClient.Get(ctx, types.NamespacedName{
-			Name:      q.Name,
-			Namespace: q.Namespace,
+			Name:      exchange.Name,
+			Namespace: exchange.Namespace,
 		}, fetchedExchange)).To(Succeed())
 
 		Expect(fetchedExchange.Spec.Name).To(Equal("test-exchange"))

diff --git a/api/v1alpha1/user_types_test.go b/api/v1alpha1/user_types_test.go
@@ -70,17 +70,17 @@ var _ = Describe("user spec", func() {
 			})
 			It("successfully creates the user", func() {
 				Expect(k8sClient.Create(ctx, &user)).To(Succeed())
-				fetcheduser := &User{}
+				fetchedUser := &User{}
 				Expect(k8sClient.Get(ctx, types.NamespacedName{
 					Name:      user.Name,
 					Namespace: user.Namespace,
-				}, fetcheduser)).To(Succeed())
-				Expect(fetcheduser.Spec.RabbitmqClusterReference).To(Equal(RabbitmqClusterReference{
+				}, fetchedUser)).To(Succeed())
+				Expect(fetchedUser.Spec.RabbitmqClusterReference).To(Equal(RabbitmqClusterReference{
 					Name:      "some-cluster",
 					Namespace: namespace,
 				}))
-				Expect(fetcheduser.Spec.Name).NotTo(BeEmpty())
-				Expect(fetcheduser.Spec.Name).To(Equal(username))
+				Expect(fetchedUser.Spec.Name).NotTo(BeEmpty())
+				Expect(fetchedUser.Spec.Name).To(Equal(username))
 			})
 		})