Skip to content

Commit

Permalink
Remove redundant checks in binding webhook
Browse files Browse the repository at this point in the history
  • Loading branch information
ChunyiLyu committed Mar 24, 2021
1 parent c0b4d9c commit d6910e8
Showing 1 changed file with 0 additions and 8 deletions.
8 changes: 0 additions & 8 deletions api/v1alpha1/binding_webhook.go
Original file line number Diff line number Diff line change
Expand Up @@ -69,14 +69,6 @@ func (b *Binding) ValidateUpdate(old runtime.Object) error {
))
}

if b.Spec.DestinationType != oldBinding.Spec.DestinationType {
allErrs = append(allErrs, field.Invalid(
field.NewPath("spec", "destinationType"),
b.Spec.DestinationType,
"destinationType cannot be updated",
))
}

if b.Spec.RoutingKey != oldBinding.Spec.RoutingKey {
allErrs = append(allErrs, field.Invalid(
field.NewPath("spec", "routingKey"),
Expand Down

0 comments on commit d6910e8

Please sign in to comment.