Refactor federation spec.uri to spec.uriSecret #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChunyiLyu
force-pushed
the
federation-uri-secret
branch
from
160795a
to
84399cf
Compare
MirahImage
reviewed
May 27, 2021
| properties: | ||
| name: | ||
| description: 'Name of the referent. More info: https://kubernetes.io/docs/concepts/overview/working-with-objects/names/#names | ||
| TODO: Add other useful fields. apiVersion, kind, uid?' |
There was a problem hiding this comment.
Is the TODO still meant to be here?
There was a problem hiding this comment.
It comes from kubernetes api corev1.LocalObjectReference directly: https://github.com/kubernetes/api/blob/b0d9a0e45e6f6f7c5f18d76d950a4d19e41d1f50/core/v1/types.go#L5407
coro
suggested changes
May 27, 2021
- federation upstream uri contains credentials and should not be saved in a CR manifest directly
ChunyiLyu
force-pushed
the
federation-uri-secret
branch
from
84399cf
to
499827a
Compare
coro
approved these changes
May 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #
Note to reviewers: remember to look at the commits in this PR and consider if they can be squashed
Note to contributors: remember to re-generate client set if there are any API changes
Summary Of Changes
Additional Context