Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bindings.rabbitmq.com webhook to prevent updates on binding.spec #72

Merged
merged 7 commits into from
Mar 18, 2021

Conversation

ChunyiLyu
Copy link
Contributor

@ChunyiLyu ChunyiLyu commented Mar 17, 2021

This closes #66

Note to reviewers: remember to look at the commits in this PR and consider if they can be squashed

Summary Of Changes

  • add make target make cert-manager to install cert manager 1.2
  • add validation admission webhook to bindings.rabbitmq.com
  • make binding.spec update not allow; error message "admission webhook \"vbinding.kb.io\" denied the request: Binding.rabbitmq.com \"binding-test\" is forbidden: spec: Forbidden: binding.spec is immutable"
  • add cert-manager an optional requirement in README
  • will provide detailed documentation on how to install without cert-manager in follow up story: provide document for deploying operator without cert manager #73

Additional Context

@ChunyiLyu ChunyiLyu changed the title Binding webhook bindings.rabbitmq.com webhook to prevent updates on binding.spec Mar 17, 2021
- will add more detailed documentation about how to install without
cert-manager as part of: #73
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Operator should not allow updates on binding.spec
2 participants