Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing olm #767

Merged
merged 9 commits into from
Mar 7, 2024
Merged

Testing olm #767

merged 9 commits into from
Mar 7, 2024

Conversation

DanielePalaia
Copy link
Contributor

@DanielePalaia DanielePalaia commented Mar 1, 2024

Similar to rabbitmq/cluster-operator#1569.

This PR is part of the task to migrate our Concourse pipelines to github actions:

It is migrating the OLM pipeline in order to test our OLM bundle in the messaging-topology-operator:
https://github.com/pivotal/rabbitmq-for-kubernetes-ci/blob/main/pipelines/olm-bundles/pipeline.yml

it can be useful to have a look to this guideline in order to see how to create and publish an OLM bundle:
https://devopstales.github.io/home/oml/

The test images are stored in the environment variable specified in:
DOCKER_REGISTRY_SERVER: quay.io/rabbitmqoperator
OLM_IMAGE: rabbitmq-for-kubernetes-olm-messaging-topology-operator
OLM_INDEX_IMAGE: rabbitmq-for-kubernetes-olm-messaging-topology-operator-index

@DanielePalaia DanielePalaia marked this pull request as draft March 1, 2024 14:00
@DanielePalaia DanielePalaia marked this pull request as ready for review March 4, 2024 14:41
@DanielePalaia DanielePalaia force-pushed the testing_olm branch 4 times, most recently from 9e12bbf to faf40dc Compare March 5, 2024 09:17
@DanielePalaia DanielePalaia force-pushed the testing_olm branch 4 times, most recently from 33b982f to c64b43a Compare March 6, 2024 12:48
Copy link
Contributor

@Zerpet Zerpet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess you are still working on this PR 🚧 A suggestion, can we use the Checkout Action instead of git clone?

It's a bit hard to understand and read through the "create" task with all the setup intertwined with the actual commands to generate the bundle.

@Zerpet
Copy link
Contributor

Zerpet commented Mar 6, 2024

This hasn't updated in a long time, but perhaps it still creates the bundle that we can use?

https://github.com/marketplace/actions/olm-bundle

@DanielePalaia
Copy link
Contributor Author

DanielePalaia commented Mar 7, 2024

@Zerpet yes it is nicer to use checkout, I will fix it.

About this https://github.com/marketplace/actions/olm-bundle it is quite interesting.
I spent some time trying to find a script to do this conversion before implementing the simple script in: https://github.com/rabbitmq/OLM-Package-Repo
but I wasn't able to find anything except the script that operatorhub has in its own UI (without any reusable code).
I didn't think to search for a github-action.

If the action is working we can use directly that one avoiding to refactor and maintaining that script which is good.
Anyway this will take more testing. At this point I would prefer to do this testing eventually in a new iteration/PR as part of the issue we have to review this OLM part in general and in the meantime go ahead with this PR as I already integrated rabbitmq/OLM-Package-Repo#8 which may make the old publishing PR not working anymore

@DanielePalaia
Copy link
Contributor Author

I replaced the git clones with the better checkout actions and I have tested it. I will now merge this one to test it on the next release. We can come back here when we will improve the OLM packaging script.

@DanielePalaia DanielePalaia merged commit 6863bcf into main Mar 7, 2024
5 checks passed
@DanielePalaia DanielePalaia deleted the testing_olm branch March 7, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants