Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validation webhooks for users, vhosts, and policies #78

Merged
merged 3 commits into from
Mar 22, 2021

Conversation

ChunyiLyu
Copy link
Contributor

@ChunyiLyu ChunyiLyu commented Mar 19, 2021

This closes #79

Note to reviewers: remember to look at the commits in this PR and consider if they can be squashed

Summary Of Changes

  • validation webhooks for users.rabbitmq.com, vhosts.rabbitmq.com, and policies.rabbitmq.com.
  • Updates on object name, vhost, and rabbitmqClusterReference will all result in a Forbidden error because allowing such updates means users can create multiple objects with updates, leaving previous object orphaned and cannot be deleted by the controller.
  • Updates on users.spec.tags, vhosts.spec.tracing, and policies properties other than name, vhost, and rabbitmqClusterReference, are allowed by the controller and the RMQ server.

Additional Context

Tested in unit tests and system tests. After this PR is approved and merged, I will start writing documentation on how to install the operator without cert-manager.

@ChunyiLyu ChunyiLyu merged commit dc8357e into main Mar 22, 2021
@ChunyiLyu ChunyiLyu deleted the vhost-policy-user-webhooks branch March 22, 2021 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not allow updates on resource names, vhosts and RabbitmqClusterReference
2 participants