WAL: drop entries with indexes lower or equal to the last snapshot #445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjnilsson
force-pushed
the
wal-drop-entries-lower-than-snap
branch
3 times, most recently
from
16d23ce
to
4818da8
Compare
kjnilsson
changed the title
kjnilsson
force-pushed
the
wal-drop-entries-lower-than-snap
branch
from
4818da8
to
40cedac
Compare
In situations where the WAL lags behind but entries are still committed the WAL will still write entries with indexes lower than the last snapshot index for a given server. To avoid this unnessary work we no check the ra_log_snapshot_state table for each write and do not write them if they are lower than the snapshot index. This allows the wal a better chance to catch up on it's backlog. Some changes needed to be made to the ra_log also to handle this new behaviour.
kjnilsson
force-pushed
the
wal-drop-entries-lower-than-snap
branch
from
40cedac
to
5b7a265
Compare
the-mikedavis
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In situations where the WAL lags behind but entries are still
committed the WAL will still write entries with indexes lower
than the last snapshot index for a given server. To avoid this
unnessary work we no check the ra_log_snapshot_state table for
each write and do not write them if they are lower than the
snapshot index. This allows the wal a better chance to catch
up on it's backlog.
Some changes needed to be made to the ra_log also to handle
this new behaviour.