Skip to content
This repository has been archived by the owner on Nov 17, 2020. It is now read-only.

AMQP Filters #3

Closed
timbuchwaldt opened this issue Aug 11, 2017 · 7 comments
Closed

AMQP Filters #3

timbuchwaldt opened this issue Aug 11, 2017 · 7 comments

Comments

@timbuchwaldt
Copy link

Hi!
We would like to use the AMQP 1.0 client for subscribing to Azure EventHub and need filtering support ( http://www.amqp.org/specification/1.0/filters)

Are there any plans on supporting filtering?

@michaelklishin
Copy link
Member

There are but there is no ETA.

@patrickdet patrickdet mentioned this issue Mar 23, 2018
@hommeabeil
Copy link

Hi
I am also using this lib to connect with an Azure event hub and I always got errors when using the filter. I look around and it seem the problem is the filter implementation. Taken from the AMQP 1.0 doc the filter should be a described type and not a string. You can look at the change here. I am willing to do the full fix, later this week if the solution accepted.

@kjnilsson
Copy link
Contributor

@hommeabeil that change looks good to me. Please raise a PR and we can take it from there. The filter implementation was a contribution, we have little means of testing it well as we don't automate the tests suite against Azure.

@hommeabeil
Copy link

@kjnilsson Do you want the PR that I link in the issue and you will do the full fix. I am not currently set to run elixir so I can run your tests suite.

@kjnilsson
Copy link
Contributor

As I mentioned we haven't got a ready test system for filters and we're a small team so a full fix PR would be much more likely to me merged sooner than one that needs work.

@hommeabeil
Copy link

No problem, I manage to make a working environment, I am currently working on the fix.

@lukebakken
Copy link
Contributor

I assume this is fixed by #17 and #28

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants