Skip to content

Commit

Permalink
Use critical service deregistration key as provided in Consul docs
Browse files Browse the repository at this point in the history
It's DeregisterCriticalServiceAfter, not Deregister_critical_service_after.
This's been working for a long time, mostly likely because Consul
converts snake_case keys to CamelCase internally but this is unverified.
  • Loading branch information
michaelklishin committed Aug 27, 2017
1 parent 6442f4b commit b8d27c8
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion src/autocluster_consul.erl
Original file line number Diff line number Diff line change
Expand Up @@ -523,7 +523,7 @@ registration_body_maybe_add_deregister(Payload) ->
-> list().
registration_body_maybe_add_deregister(Payload, undefined) -> Payload;
registration_body_maybe_add_deregister(Payload, Deregister_After) ->
Deregister = {'Deregister_critical_service_after',
Deregister = {'DeregisterCriticalServiceAfter',
list_to_atom(service_ttl(Deregister_After))},
Payload ++ [Deregister].
%%--------------------------------------------------------------------
Expand Down
2 changes: 1 addition & 1 deletion test/src/autocluster_consul_tests.erl
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ build_registration_body_test_() ->
[{'Notes','RabbitMQ Auto-Cluster Plugin TTL Check'},
{'TTL','30s'},
{'Status', 'passing'},
{'Deregister_critical_service_after','257s'}]}],
{'DeregisterCriticalServiceAfter','257s'}]}],
?assertEqual(Expectation, autocluster_consul:build_registration_body())
end},
{"with unset deregister and ttl", fun() ->
Expand Down

0 comments on commit b8d27c8

Please sign in to comment.