support for clustering by hostname in kubernetes #13
Conversation
| @@ -56,6 +56,8 @@ | |||
| {config, k8s_namespace_path, "K8S_NAMESPACE_PATH", "/var/run/secrets/kubernetes.io/serviceaccount/namespace", | |||
| string, false}, | |||
| {config, k8s_service_name, "K8S_SERVICE_NAME", "rabbitmq", string, false}, | |||
| {config, k8s_address_type, "K8S_ADDRESS_TYPE", "ip", string, false}, | |||
There was a problem hiding this comment.
If the options here are ip and hostname, please leave a comment mentioning that.
There was a problem hiding this comment.
Actually, the rest looks good so I will add one myself.
|
@pavel987 thank you! |
|
Thank you for your work, @pavel987 and @michaelklishin. What do you think could we have this also for RabbitMQ v3.6.x? |
|
@Gsantomaggio @dcorbacho does this seem like something you'd agree to backport? |
|
IMHO this is crucial to get a cluster on k8s with persistence. If using IPs, the cluster will loose it's database (incl. users, ...) sooner or later because the IPs change if a pod gets stopped/started. I got the code working on the |
|
Yes! |
|
@luxflux please do. |
Copying my pull request from aweber#118