Support hostname from nodename in consul using CONSUL_SVC_ADDR_NODENAME #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adresses user request to select the long nodename given instead of retrieving it from inets. [#141944663] aweber#62
| @@ -35,6 +35,7 @@ | |||
| {config, consul_svc_addr, "CONSUL_SVC_ADDR", "undefined", string, false}, | |||
| {config, consul_svc_addr_auto, "CONSUL_SVC_ADDR_AUTO", false, atom, false}, | |||
| {config, consul_svc_addr_nic, "CONSUL_SVC_ADDR_NIC", "undefined", string, false}, | |||
| {config, consul_svc_addr_nodename, "CONSUL_SVC_ADDR_NODENAME", false, atom, false}, | |||
There was a problem hiding this comment.
Since we have USE_LONGNAME can we use directly it without add another variable ? CONSUL_SVC_ADDR_NODENAME, WDYT?
There was a problem hiding this comment.
No, it would change the actual behaviour. In this case, it is optional and only interested users need to configure it.
|
LGTM! |
michaelklishin
approved these changes
Mar 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adresses user request to select the long nodename given instead of
retrieving it from inets.
[#141944663]
aweber#62