Skip to content
This repository has been archived by the owner on Jan 11, 2023. It is now read-only.

CMake Build System #3

Closed
wants to merge 21 commits into from
Closed

CMake Build System #3

wants to merge 21 commits into from

Conversation

alanxz
Copy link
Collaborator

@alanxz alanxz commented Oct 25, 2011

Created a cmake-based build system.

The benefit being it can be built just as easily on Windows (MSVC, MinGW), Linux and Mac.

First time sending a pull request to you, let me know if I should be going through a different channel.

@dpw
Copy link
Contributor

dpw commented Nov 4, 2011

With workarounds for those three issues, I've built under Linux, Visual Studio 10 and mingw/msys, and it looks good. It will be great to have a proper visual studio build.

Codegen.py should be copied to the bin directory and not the source
directory.
stdint.h is provided by MinGW/MSYS on Win32. It is not provided by MSVC
@alanxz
Copy link
Collaborator Author

alanxz commented Nov 4, 2011

The only other thing I can think of at this point is the ability for the user to choose whether to build a shared or static library. Right now it unconditionally creates a shared library.

@dpw
Copy link
Contributor

dpw commented Nov 4, 2011

I'm happy to merge without support for building static libs. Static libs might be nice, but I guess support for them can easily be added later on.

@alanxz
Copy link
Collaborator Author

alanxz commented Nov 4, 2011

Ok. Go ahead an merge away!

@dpw
Copy link
Contributor

dpw commented Nov 4, 2011

Merged. Because the changes had to go through our hg repo, the git commit IDs have changed in the merge process.

(I can sometimes get the commit IDs to round-trip through hg and stay the same, but in this case some commits had distinct authors and committers which hg doesn't understand.)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants