This repository has been archived by the owner on Jan 11, 2023. It is now read-only.
Add plumbing for SSL/TLS support #7
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change abstracts out the networking functions so that the user can provide an SSL/TLS implementation. Signed-off-by: Michael Steinert <mike.steinert@gmail.com>
|
@msteinert could you submit your pull-request(s) to https://github.com/alanxz/rabbitmq-c. That is currently where the 'official' rabbitmq-c code is. Also we had a somewhat crude start to this, that I haven't had a lot of time to massage into form yet, I'm excited to see what you've put together: |
Closed
|
In an effort to transition away from this repository, I'm closing this pull-request. When you get a chance could you re-submit the pull request against alanxz/rabbitmq-c. My apologies for the inconvenience. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change abstracts out the networking functions so that the user can provide an SSL/TLS implementation. Below is an explanation of the changes included.
SSL/TLS plumbing
Callback functions replace
writev(),send(), andrecv()(there is also a callback for error reporting). The default interface remains unchanged. If the user wants to create a SSL/TLS connection they first negotiate the connection and then use the new functionamqp_set_sockfd_full()to provide the networking implementation for their SSL/TLS library. The user may provide an optional pointer to data that is passed through to the networking functions.I'm still running tests but I thought I would submit it early to get some feedback. The coding style seems a bit variable so I tried to follow the surrounding code in each file.