This repository has been archived by the owner on Nov 18, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 34
CLI definition export incorrectly serialises federation upstreams #435
Comments
This is how parameters in the problematic case are deserialised:
|
JSON file difference makes it clear it's an "parameters": [
{
"component": "federation-upstream",
"name": "up-1",
"value": [
[
"ack-mode",
"on-confirm"
],
[
"trust-user-id",
false
],
[
"uri",
"amqp://127.0.0.1:5672"
]
],
"vhost": "/"
},
{
"component": "shovel",
"name": "shovel-60",
"value": [
[
"ack-mode",
"on-confirm"
],
[
"dest-add-forward-headers",
false
],
[
"dest-protocol",
"amqp091"
],
[
"dest-queue",
"shovel-60-dst"
],
[
"dest-uri",
"amqp://localhost:5672"
],
[
"src-delete-after",
"never"
],
[
"src-protocol",
"amqp091"
],
[
"src-queue",
"shovel-60-src"
],
[
"src-uri",
"amqp://localhost:5672"
]
],
"vhost": "/"
}
], vs. HTTP API-produced one: "parameters": [
{
"value": {
"ack-mode": "on-confirm",
"trust-user-id": false,
"uri": "amqp://127.0.0.1:5672"
},
"vhost": "/",
"component": "federation-upstream",
"name": "up-1"
},
{
"value": {
"ack-mode": "on-confirm",
"dest-add-forward-headers": false,
"dest-protocol": "amqp091",
"dest-queue": "shovel-60-dst",
"dest-uri": "amqp://localhost:5672",
"src-delete-after": "never",
"src-protocol": "amqp091",
"src-queue": "shovel-60-src",
"src-uri": "amqp://localhost:5672"
},
"vhost": "/",
"component": "shovel",
"name": "shovel-60"
}
], |
michaelklishin
referenced
this issue
in rabbitmq/rabbitmq-server
Jun 26, 2020
Fixes the issue described here: rabbitmq/rabbitmq-schema-definition-sync#2 (comment)
michaelklishin
added a commit
that referenced
this issue
Jun 26, 2020
otherwise it would be serialised as a list of pairs, which is not the format the import path (or an operator) expects Closes #435
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
"Incorrectly" here means it uses keyword lists instead of maps:
This issue is not present with a file produced by the HTTP API.
Discovered while working on rabbitmq/rabbitmq-server#2384.
Apparently it was introduced by this change rabbitmq/rabbitmq-server@460a432 that makes exported parameter values to be proplists and not maps.
The text was updated successfully, but these errors were encountered: