This repository has been archived by the owner on Nov 18, 2020. It is now read-only.
Feature flag commands: handle missing rabbit_ff_extra modules on target node #344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes, it should return an empty list of feature flags: RabbitMQ itself does exactly that, i.e. the absence of the feature flags subsystem is not an error. |
…node Part of #343. [#163980302]
michaelklishin
force-pushed
the
rabbitmq-cli-343
branch
from
639b1c3
to
305ee1a
Compare
…available Per discussion with @dumbbell. [#163980302]
…the flag or any flags. [#163980302]
|
Ready for another round. |
michaelklishin
changed the title
|
Merging per verbal approval from @dumbbell. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes
ctl list_feature_flagshandle missing rabbit_ff_extra modules on target node.@dumbbell @lukebakken @gerhard if this is the behavior we want I will extend it to more commands. Alternatively we could return an empty list of feature flags (this may be more operator-friendly during upgrades).
[#163980302]