This repository has been archived by the owner on Nov 17, 2020. It is now read-only.
Default memory high watermark to 1.0 when using a higher value #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this change, setting the vm_memory_high_watermark to a value higher than 1 (inclusive), would default to 0.4. This is different from the behaviour when setting an absolute value, namely defaulting to the total memory available. Extracted common memory-related macros & records so that they can be shared by tests. re rabbitmq/rabbitmq-server#1285 [finishes #148470947]
michaelklishin
suggested changes
Jul 10, 2017
include/rabbit_memory.hrl
Outdated
| -define(DEFAULT_VM_MEMORY_HIGH_WATERMARK, 0.4). | ||
| -define(MAX_VM_MEMORY_HIGH_WATERMARK, 1.0). | ||
|
|
||
| -record(state, {total_memory, |
There was a problem hiding this comment.
I'm afraid state is overly generic for a record in a shared header. Please rename this to vm_mem_monitor_state or vm_memory_state?
There was a problem hiding this comment.
In fact, since this record is only used in one module, we can move it to vm_memory_monitor.
michaelklishin
approved these changes
Jul 11, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change, setting the vm_memory_high_watermark to a value
higher than 1 (inclusive), would default to 0.4. This is different from
the behaviour when setting an absolute value, which defaults to the
total memory available.
Extracted common memory-related macros so that they can be
shared by tests.
re rabbitmq/rabbitmq-server#1285
[finishes #148470947]