This repository has been archived by the owner on Nov 17, 2020. It is now read-only.
Support for parallel info emission #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| wait_for_info_messages(Pid, Ref, ArgAtoms, DisplayFun, Timeout) -> | ||
| _ = notify_if_timeout(Pid, Ref, Timeout), | ||
| wait_for_info_messages(Ref, ArgAtoms, DisplayFun). | ||
| wait_for_info_messages(Pid, Ref, DisplayFun, Timeout, Chunks) -> |
There was a problem hiding this comment.
I'd rename Chunks to NodesCount and NodesLeft or something like that, so that it is obvious what exactly the function is waiting for.
binarin
force-pushed
the
rabbitmq-server-parallel-listing
branch
5 times, most recently
from
e062832
to
48b866d
Compare
binarin
changed the title
michaelklishin
changed the title
binarin
force-pushed
the
rabbitmq-server-parallel-listing
branch
from
48b866d
to
c7e0a2d
Compare
michaelklishin
changed the title
binarin
force-pushed
the
rabbitmq-server-parallel-listing
branch
3 times, most recently
from
455028c
to
336f06b
Compare
|
@binarin I have conflicts when merging this. |
- Emit info about particular items in parallel on every node, with results delivered directly to a `rabbitmqctl` instance. - `rabbit_control_misc:wait_for_info_messages/5` can wait for results of more than one emitting map. - Stop passing arround InfoItemKeys in `rabbit_control_misc:wait_for_info_messages/5`, the same information could be directly encoded in DisplayFun closure. - Add `emit` to function names, to avoid confusion with regular ones which return result directly. Part of rabbitmq/rabbitmq-server#683
binarin
force-pushed
the
rabbitmq-server-parallel-listing
branch
from
336f06b
to
7dc7493
Compare
|
Updated patch. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Complement for rabbitmq/rabbitmq-server#683
rabbit_control_misc:wait_for_info_messages/5can wait for results ofmore than one emitting map.
rabbit_control_misc:wait_for_info_messages/5, the same informationcould be directly encoded in DisplayFun closure.
emitto function names, to avoid confusion with regular oneswhich return result directly.