-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update for RabbitMQ 3.13 #264
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we would want this to follow the 3.13.x branch instead of main?
@pjk25 My plan is to merge this to I could just rename |
Yup, just like with other branches and plugins. |
The tests fail, something khepri related https://app.buildbuddy.io/invocation/99857d85-5002-453d-a78a-cbee7e49957d?target=%2F%2F%3Aplugin_SUITE&targetStatus=6 |
I meant this change: index 17a2196..d00f919 100644
--- a/MODULE.bazel
+++ b/MODULE.bazel
@@ -32,9 +32,9 @@ bazel_dep(
archive_override(
module_name = "rabbitmq-server",
- strip_prefix = "rabbitmq-server-main",
+ strip_prefix = "rabbitmq-server-3.13.x",
urls = [
- "https://github.com/rabbitmq/rabbitmq-server/archive/refs/heads/main.zip",
+ "https://github.com/rabbitmq/rabbitmq-server/archive/refs/heads/v3.13.x.zip",
],
) Probably best to create the v3.13.x branch on this repo, merge this PR to it, then have a separate PR for main. Other option is to make the above diff part of this PR, but then revert it on main of this repo |
ab88424
to
c775668
Compare
@pjk25 - I think this PR represents what you suggested. Merge to |
Fixes #263