Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for RabbitMQ 3.13 #264

Merged
merged 1 commit into from
Mar 11, 2024
Merged

Conversation

lukebakken
Copy link
Contributor

Fixes #263

@lukebakken lukebakken self-assigned this Mar 5, 2024
@lukebakken lukebakken requested a review from pjk25 March 5, 2024 23:54
@lukebakken lukebakken added this to the 3.13.0 milestone Mar 5, 2024
Copy link
Contributor

@pjk25 pjk25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we would want this to follow the 3.13.x branch instead of main?

.github/workflows/test.yml Outdated Show resolved Hide resolved
@lukebakken
Copy link
Contributor Author

I think we would want this to follow the 3.13.x branch instead of main?

@pjk25 My plan is to merge this to main, then immediately create a v3.13.x branch on that commit.

I could just rename main to v3.13.x, too. Thoughts?

cc @michaelklishin

@michaelklishin
Copy link
Member

Yup, just like with other branches and plugins.

@pjk25
Copy link
Contributor

pjk25 commented Mar 7, 2024

@pjk25
Copy link
Contributor

pjk25 commented Mar 7, 2024

I think we would want this to follow the 3.13.x branch instead of main?

@pjk25 My plan is to merge this to main, then immediately create a v3.13.x branch on that commit.

I could just rename main to v3.13.x, too. Thoughts?

cc @michaelklishin

I meant this change:

index 17a2196..d00f919 100644
--- a/MODULE.bazel
+++ b/MODULE.bazel
@@ -32,9 +32,9 @@ bazel_dep(

 archive_override(
     module_name = "rabbitmq-server",
-    strip_prefix = "rabbitmq-server-main",
+    strip_prefix = "rabbitmq-server-3.13.x",
     urls = [
-        "https://github.com/rabbitmq/rabbitmq-server/archive/refs/heads/main.zip",
+        "https://github.com/rabbitmq/rabbitmq-server/archive/refs/heads/v3.13.x.zip",
     ],
 )

Probably best to create the v3.13.x branch on this repo, merge this PR to it, then have a separate PR for main. Other option is to make the above diff part of this PR, but then revert it on main of this repo

Fixes #263

Address @pjk25 review comment

Remove OTP 25 since RMQ 3.13 does NOT support it.

Apply fix proposed by @dumbbell

update mk files

Remove 3.11
@lukebakken lukebakken force-pushed the rabbitmq-delayed-message-exchange-263 branch from ab88424 to c775668 Compare March 8, 2024 19:39
@lukebakken lukebakken changed the base branch from main to v3.13.x March 8, 2024 22:42
@lukebakken lukebakken requested a review from pjk25 March 8, 2024 22:53
@lukebakken lukebakken marked this pull request as ready for review March 8, 2024 22:53
@lukebakken
Copy link
Contributor Author

@pjk25 - I think this PR represents what you suggested. Merge to v3.13.x, different PR for main

@lukebakken lukebakken merged commit 08c3571 into v3.13.x Mar 11, 2024
4 checks passed
@lukebakken lukebakken deleted the rabbitmq-delayed-message-exchange-263 branch March 11, 2024 18:02
lukebakken added a commit that referenced this pull request Mar 11, 2024
Part of #263
lukebakken added a commit that referenced this pull request Mar 11, 2024
Part of #263
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for RabbitMQ 3.13.x
3 participants