* Try to figure out CI error here - https://github.com/rabbitmq/rabbi…

…tmq-dotnet-client/actions/runs/8072267202/job/22053764839
rabbitmq · Feb 28, 2024 · 69a4201 · 69a4201
1 parent 095988f
commit 69a4201
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 2 deletions.
diff --git a/projects/RabbitMQ.Client/client/impl/ChannelBase.cs b/projects/RabbitMQ.Client/client/impl/ChannelBase.cs
@@ -471,6 +471,11 @@ private void OnSessionShutdown(object sender, ShutdownEventArgs reason)
 
         internal bool SetCloseReason(ShutdownEventArgs reason)
         {
+            if (reason is null)
+            {
+                throw new ArgumentNullException(nameof(reason));
+            }
+
             // NB: this ensures that Close is only called once on a channel
             return Interlocked.CompareExchange(ref _closeReason, reason, null) is null;
         }

diff --git a/projects/RabbitMQ.Client/client/impl/SessionBase.cs b/projects/RabbitMQ.Client/client/impl/SessionBase.cs
@@ -111,6 +111,7 @@ public void Close(ShutdownEventArgs reason, bool notify)
             {
                 RabbitMqClientEventSource.Log.ChannelClosed();
             }
+
             if (notify)
             {
                 OnSessionShutdown(CloseReason);
@@ -126,7 +127,7 @@ public void Notify()
             ShutdownEventArgs reason = CloseReason;
             if (reason is null)
             {
-                throw new InvalidOperationException("Internal Error in Session.Close");
+                throw new InvalidOperationException("Internal Error in SessionBase.Notify");
             }
 
             OnSessionShutdown(reason);

diff --git a/projects/Test/Integration/TestConnectionRecoveryWithoutSetup.cs b/projects/Test/Integration/TestConnectionRecoveryWithoutSetup.cs
@@ -149,7 +149,7 @@ public async Task TestConsumerWorkServiceRecovery()
         [Fact]
         public async Task TestConsumerRecoveryOnClientNamedQueueWithOneRecovery()
         {
-            string q0 = "dotnet-client.recovery.queue1";
+            const string q0 = "dotnet-client.recovery.queue1";
             using (AutorecoveringConnection c = await CreateAutorecoveringConnectionAsync())
             {
                 using (IChannel ch = await c.CreateChannelAsync())