Removed ReceiveBufferSize and SendBufferSize to improve message rates

Add test
rabbitmq · Nov 15, 2023 · b8f6832 · b8f6832
1 parent 739a46a
commit b8f6832
Show file tree

Hide file tree

Showing 2 changed files with 31 additions and 3 deletions.
diff --git a/projects/RabbitMQ.Client/client/api/ConnectionFactoryBase.cs b/projects/RabbitMQ.Client/client/api/ConnectionFactoryBase.cs
@@ -51,9 +51,7 @@ public static ITcpClient DefaultSocketFactory(AddressFamily addressFamily)
         {
             var socket = new Socket(addressFamily, SocketType.Stream, ProtocolType.Tcp)
             {
-                NoDelay = true,
-                ReceiveBufferSize = 65536,
-                SendBufferSize = 65536
+                NoDelay = true
             };
             return new TcpClientAdapter(socket);
         }

diff --git a/projects/Unit/TestConnectionFactory.cs b/projects/Unit/TestConnectionFactory.cs
@@ -30,7 +30,9 @@
 //---------------------------------------------------------------------------
 
 using System.Collections.Generic;
+using System.Net.Sockets;
 using RabbitMQ.Client.Exceptions;
+using RabbitMQ.Client.Impl;
 using Xunit;
 
 namespace RabbitMQ.Client.Unit
@@ -69,6 +71,34 @@ public void TestProperties()
             Assert.Equal(cf.Endpoint.MaxMessageSize, mms);
         }
 
+        [Fact]
+        public void TestConnectionFactoryWithCustomSocketFactory()
+        {
+            const int bufsz = 1024;
+
+            ConnectionFactory cf = new()
+            {
+                SocketFactory = (AddressFamily af) =>
+                {
+                    var socket = new Socket(af, SocketType.Stream, ProtocolType.Tcp)
+                    {
+                        SendBufferSize = bufsz,
+                        ReceiveBufferSize = bufsz,
+                        NoDelay = false
+                    };
+                    return new TcpClientAdapter(socket);
+                }
+            };
+
+            ITcpClient c = cf.SocketFactory(AddressFamily.InterNetwork);
+            Assert.IsType<TcpClientAdapter>(c);
+            TcpClientAdapter tcpClientAdapter = (TcpClientAdapter)c;
+            Socket s = tcpClientAdapter.Client;
+            Assert.Equal(bufsz, s.ReceiveBufferSize);
+            Assert.Equal(bufsz, s.SendBufferSize);
+            Assert.False(s.NoDelay);
+        }
+
         [Fact]
         public void TestCreateConnectionUsesSpecifiedPort()
         {