Separate out connection recovery tests #1549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow these slow tests to run in parallel (cherry picked from commit d3d7195)
lukebakken
changed the title
Add assertion to see if test fails earlier * Fix `TestBindingRecovery_GH1035` * Fix `QueueUnbindAsync` default argument in `IChannel` * Rename variables in test to make it easier to understand * Check for unexpected callback exceptions. * Add `ConnectionRecoveryError` handler check * Modify `TestPublishRpcRightAfterReconnect` to just log error condition * Disregard "unexpected" exceptions in `TestConnectionRecovery` * Do not use the `amq.fanout` fanout exchange because messages published to it could end up in tests that should note have messages, like `TestConcurrentQueueDeclareAndBindAsync`
lukebakken
force-pushed
the
lukebakken/connectionrecovery-test-speedup
branch
from
5c23c76
to
10e58e4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow these slow tests to run in parallel.