Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable rabbitmq-client event logging when tests are verbose #1559

Merged
merged 1 commit into from
May 9, 2024

Conversation

lukebakken
Copy link
Contributor

  • Fix event ID issue by duplicating Error Event 3 code for each target framework.
  • Fix strange null reference exception by not using ??= lazy init.

@lukebakken lukebakken modified the milestones: 6.9.0, 7.0.0 May 8, 2024
@lukebakken lukebakken self-assigned this May 8, 2024
@lukebakken lukebakken requested a review from stebet May 8, 2024 17:41
@lukebakken lukebakken force-pushed the lukebakken/fix-eventsource branch 2 times, most recently from 06a4924 to 009eaf4 Compare May 9, 2024 16:34
* Fix event ID issue by duplicating Error Event 3 code for each target framework.
* Fix strange null reference exception by not using `??=` lazy init.
*

* Remove `Message` from `RabbitMqClientEventSource` because it does not work as intended.

* Handle task canceled exception in main loop.

* Ignore a couple exception cases in the `MainLoop`
@lukebakken lukebakken marked this pull request as ready for review May 9, 2024 17:48
@lukebakken lukebakken merged commit d39d79a into main May 9, 2024
11 checks passed
@lukebakken lukebakken deleted the lukebakken/fix-eventsource branch May 9, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant