Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement AutoCloseable in Channel #258

Closed
boryspiela opened this issue Mar 13, 2017 · 3 comments · Fixed by #261
Closed

Implement AutoCloseable in Channel #258

boryspiela opened this issue Mar 13, 2017 · 3 comments · Fixed by #261

Comments

@boryspiela
Copy link

boryspiela commented Mar 13, 2017

It would be nice to implement AutoCloseable interface in Channel class and override its' close method.
AutoCloseable implementation was previously done in #131 in Connection class but Channel was left with a comment "I wanted to add it to Channel-class also but it had a checked exception TimedOutException that broke the contract of Closeable so I avoided it." (#133) but there is no specification for close method to not throw java.util.concurrent.TimeoutException. close method should not throw java.lang.InterruptedException.

@michaelklishin
Copy link
Member

The docs seem to concur. Now that we are working on 5.0 targeting JDK 8, we can reconsider this.

@zaharidichev
Copy link

Can i have a take on that one ?

@michaelklishin
Copy link
Member

@zaharidichev sure, why not. Take a look at CONTRIBUTING.md. I believe this change is small enough to not require a signed CA but if you could file on, it'd be particularly appreciated. Thank you!

venilnoronha added a commit to venilnoronha/rabbitmq-java-client that referenced this issue Apr 11, 2017
venilnoronha added a commit to venilnoronha/rabbitmq-java-client that referenced this issue Apr 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants