You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It would be nice to implement AutoCloseable interface in Channel class and override its' close method. AutoCloseable implementation was previously done in #131 in Connection class but Channel was left with a comment "I wanted to add it to Channel-class also but it had a checked exception TimedOutException that broke the contract of Closeable so I avoided it." (#133) but there is no specification for close method to not throw java.util.concurrent.TimeoutException. close method should not throw java.lang.InterruptedException.
The text was updated successfully, but these errors were encountered:
@zaharidichev sure, why not. Take a look at CONTRIBUTING.md. I believe this change is small enough to not require a signed CA but if you could file on, it'd be particularly appreciated. Thank you!
venilnoronha
added a commit
to venilnoronha/rabbitmq-java-client
that referenced
this issue
Apr 11, 2017
It would be nice to implement
AutoCloseable
interface inChannel
class and override its'close
method.AutoCloseable
implementation was previously done in #131 inConnection
class butChannel
was left with a comment "I wanted to add it to Channel-class also but it had a checked exception TimedOutException that broke the contract of Closeable so I avoided it." (#133) but there is no specification forclose
method to not throwjava.util.concurrent.TimeoutException
.close
method should not throwjava.lang.InterruptedException
.The text was updated successfully, but these errors were encountered: