Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds required command line args to GraalVM native-image command. #666

Merged
merged 2 commits into from
Feb 2, 2021
Merged

Adds required command line args to GraalVM native-image command. #666

merged 2 commits into from
Feb 2, 2021

Conversation

rjbaucells
Copy link
Contributor

@rjbaucells rjbaucells commented Feb 2, 2021

Proposed Changes

GraalVM native image generation requires all resources to be explicitly added to the final image using the command line argument -H:IncludeResources=resource1|resource2|...|resourceN.

Libraries can specify the required command line arguments to the native-image command by creating a resource in the following location:

META-INF/native-image/${groupId}/${artifactId}/native-image.properties

See Native Image Build Configuration documentation for more details.

Types of Changes

What types of changes does your code introduce to this project?

  • Bugfix (non-breaking change which fixes issue #NNNN)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (correction or otherwise)
  • Cosmetics (whitespace, appearance)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating
the PR. If you're unsure about any of them, don't hesitate to ask on the
mailing list. We're here to help! This is simply a reminder of what we are
going to look for before merging your code.

  • I have read the CONTRIBUTING.md document
  • I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
  • All tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in related repositories

@pivotal-issuemaster
Copy link

@rjbaucells Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-issuemaster
Copy link

@rjbaucells Thank you for signing the Contributor License Agreement!

@michaelklishin michaelklishin merged commit 87661ee into rabbitmq:5.x.x-stable Feb 2, 2021
@michaelklishin
Copy link
Member

Thank you!

@michaelklishin
Copy link
Member

This can be backported and included into a patch release if necessary. Let us know.

@rjbaucells rjbaucells deleted the graalvm-native-image branch February 2, 2021 21:15
@rjbaucells
Copy link
Contributor Author

I think it is a good idea to port it to 5.10.X release so it is available now. I can do a PR if needed, just let me know the branch I should as target for the PR.

@acogoluegnes
Copy link
Contributor

We should release 5.11.0.RC1 pretty soon (hopefully this week).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants