Add support for publisher confirms #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add an optional callback to the RMQConnectionFactory to be notified of confirmed/nack-ed published messages. Setting this callback will enable publisher confirms globally (for all the children objects created by the RMQConnectionFactory instance). Publisher confirms use a publishing sequence number to correlate messages. As there is no such concept in JMS, the JMS client takes care of mapping sequence numbers with original messages. The confirm callback has one method with one context parameter. This allows adding more information about published messages later (e.g. the session or producer instance), without breaking changes. The context consists now of the original message and a flag for confirmed or nacked. Fixes #115
Conflicts: src/main/java/com/rabbitmq/jms/admin/RMQConnectionFactory.java
michaelklishin
approved these changes
Aug 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an optional callback to the RMQConnectionFactory to be notified
of confirmed/nack-ed published messages. Setting this callback will
enable publisher confirms globally (for all the children objects created
by the RMQConnectionFactory instance).
Publisher confirms use a publishing sequence number to correlate
messages. As there is no such concept in JMS, the JMS client takes care
of mapping sequence numbers with original messages.
The confirm callback has one method with one context parameter. This
allows adding more information about published messages later (e.g. the
session or producer instance), without breaking changes. The context
consists now of the original message and a flag for confirmed or nacked.
Fixes #115