Add channel QoS setting #13
Conversation
| * | ||
| * @see com.rabbitmq.client.Channel#basicQos(int) | ||
| */ | ||
| private final int channelsQos; |
There was a problem hiding this comment.
Does this value have to be final? QoS changes on the fly are not very common but possible in AMQP 0-9-1.
There was a problem hiding this comment.
It doesn't have to be final. The intent is to have a RMQConnection creating AMQP channels with the same settings, not more. Not sure users are coding against the RMQConnection class, but more against the JMS *Connection interfaces. We can make it volatile and expose it with getter/setter, it should be harmless.
There was a problem hiding this comment.
OK, this is not how Java client works but we can safely switch it to per-session (connection) strategy later if JMS users care enough. Going the other way would be a breaking change.
| @@ -47,7 +47,9 @@ | |||
| */ | |||
| public class RMQConnection implements Connection, QueueConnection, TopicConnection { | |||
|
|
|||
| private final Logger logger = LoggerFactory.getLogger(RMQConnection.class);; | |||
| public static final int NO_CHANNEL_QOS = -1; | |||
There was a problem hiding this comment.
Is the intent here to have no limit by default? Then it should be 0.
There was a problem hiding this comment.
The intent is to skip any call to basicQos: 2a7ffc4#diff-9f6f94ce0c4ddde9be9f61d3dba10487R339
Fixes #11