Skip to content
This repository has been archived by the owner on Nov 17, 2020. It is now read-only.

Allow configuring multiple TCP listeners (non-TLS and TLS) #563

Closed
lukebakken opened this issue Apr 16, 2018 · 7 comments · Fixed by #618
Closed

Allow configuring multiple TCP listeners (non-TLS and TLS) #563

lukebakken opened this issue Apr 16, 2018 · 7 comments · Fixed by #618
Assignees
@michaelklishin
Labels
effort-low enhancement
Milestone
3.7.9

Comments

@lukebakken
Copy link
Contributor

lukebakken commented Apr 16, 2018 •
edited by michaelklishin

Please see this rabbitmq-users topic: link

Currently the management plugin only supports one listener at a time and it is not possible to support
HTTP and HTTPS clients at the same time, for instance.

[156776853] - related to [135606833]
@michaelklishin
Copy link
Member

Biggest pain point here seems to be coming up with the configuration syntax.

@michaelklishin michaelklishin added this to the 3.7.9 milestone Sep 20, 2018
@michaelklishin
Copy link
Member

michaelklishin commented Oct 17, 2018 •
edited

We can move to supporting multiple listeners and keep the current configuration compatible. Something like

management.listeners.tcp.default = 192.168.1.99:5672
management.listeners.tcp.1 = :::5672
management.listeners.tcp.2 = :::6672
management.listeners.ssl.default = ::1:15671

@michaelklishin
Copy link
Member

Another option is to do what Web STOMP and Web MQTT plugins do: they allow for 1 TCP and 1 TLS listener only:

management.tcp.port = 15672

management.ssl.port = 15671
management.ssl.cacertfile = /path/to/cacert.pem
management.ssl.certfile = /path/to/cert.pem
management.ssl.keyfile = /path/to/key.pem

@michaelklishin michaelklishin self-assigned this Oct 17, 2018
@michaelklishin
Copy link
Member

Most of our team prefer option number 2.

michaelklishin added a commit that referenced this issue Oct 18, 2018
@michaelklishin
Introduce new configuration settings for separate TCP and TLS listeners
816e83e 
To make it possible to serve both HTTPS and HTTP-only clients at the same time.
Consistent with web-stomp and web-mqtt plugins.

References #563.

[#156776853]
michaelklishin added a commit that referenced this issue Oct 18, 2018
@michaelklishin
Start TCP and TLS listeners based on what app environment keys are pr…
50957aa 
…esent

References #563.

[#156776853]
@michaelklishin michaelklishin mentioned this issue Oct 18, 2018
Merged
11 tasks
michaelklishin added a commit to rabbitmq/rabbitmq-website that referenced this issue Oct 22, 2018
@michaelklishin
Management plugin guide: updates for rabbitmq/rabbitmq-management#563
3750940
@michaelklishin michaelklishin mentioned this issue Oct 22, 2018
Merged
@michaelklishin
Copy link
Member

Doc PR: rabbitmq/rabbitmq-website#606.

@michaelklishin
Copy link
Member

Doc PR: rabbitmq/rabbitmq-website#606.

I will issue a follow-up PR to #618 that covers less frequently used Cowboy options.

michaelklishin added a commit that referenced this issue Oct 22, 2018
@michaelklishin
Support advanced Cowboy options via management.{tcp,ssl}.*
aed4cb9 
References #563.

[#156776853]
@michaelklishin michaelklishin mentioned this issue Oct 22, 2018
Merged
11 tasks
michaelklishin added a commit to rabbitmq/rabbitmq-website that referenced this issue Oct 22, 2018
@michaelklishin
Update Cowboy HTTP and WebSocket setting docs
82c90bb 
 * Updated for the settings coming in 3.7.9
 * Reduce delta between Web STOMP and Web MQTT docs
 * Remove Web Dispatch guide, it's not particularly useful now
 * Fold Web Dispatch content into Management, Web STOMP and Web MQTT guides

References rabbitmq/rabbitmq-management#563.

[#156776853]

Per discussion with @kjnilsson.
@michaelklishin
Copy link
Member

michaelklishin commented Oct 22, 2018 •
edited

Follow-up PRs: rabbitmq/rabbitmq-website#606, #619, rabbitmq/rabbitmq-website#607.

@michaelklishin michaelklishin mentioned this issue Oct 22, 2018
Merged
michaelklishin added a commit that referenced this issue Oct 23, 2018
@michaelklishin
Support advanced Cowboy options via management.{tcp,ssl}.*
a70e822 
References #563.

[#156776853]

(cherry picked from commit aed4cb9)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@michaelklishin michaelklishin

Labels
effort-low enhancement
Projects
None yet
Milestone
3.7.9
Development

Successfully merging a pull request may close this issue.

Make it possible to configure TCP and TLS listeners at the same time rabbitmq/rabbitmq-management
2 participants
@michaelklishin @lukebakken