Skip to content
This repository has been archived by the owner on Nov 17, 2020. It is now read-only.

Changed bytes converter #827

Merged
merged 1 commit into from Jul 14, 2020
Merged

Changed bytes converter #827

merged 1 commit into from Jul 14, 2020

Conversation

seadog007
Copy link
Contributor

@seadog007 seadog007 commented Jul 9, 2020 •
edited by michaelklishin

Change the convert to more human readable

The iB is weird, and it seems like typo
截圖 2020-07-09 下午5 43 17

After the PR, the i will not show when there is no prefix
截圖 2020-07-09 下午5 49 35

Types of Changes

  • Bugfix (non-breaking change which fixes issue #NNNN)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (correction or otherwise)
  • Cosmetics (whitespace, appearance)

Checklist

  • I have read the CONTRIBUTING.md document
  • I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
  • All tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in related repositories

Further Comments

N/A

@michaelklishin
Copy link
Member

This looks reasonable, we will give it a try soon, thank you!

@michaelklishin michaelklishin merged commit 961de91 into rabbitmq:master Jul 14, 2020
@michaelklishin michaelklishin added this to the 3.8.6 milestone Jul 14, 2020
@michaelklishin
Copy link
Member

Thank you!

@michaelklishin
Copy link
Member

Backported to v3.8.x.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
usability
Projects
None yet
Milestone
3.8.6
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@seadog007 @michaelklishin