Avoid RMQConnection leaks by adopting weak refs, take 2 #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelklishin
force-pushed
the
rabbitmq-objc-client-194-take-2
branch
from
e806ca0
to
3ba2990
Compare
|
This has introduced test failures that are basically |
Ok, I guess the memory graph in XCode will need be examined more closely. The upshot of all of this is that we identified a memory issue and an area for improvement in the library which is good. |
…BarryDuggan) for some important dependencies of allocated channels and RMQConnection itself. In this client, RMQConnection auto-allocates a channel for the purpose of special "channel zero" (system communication in the protocol) purposes, and that leads to a loop of strong references that prevent RMQConnection instances from being released. Contributed by @BarryDuggan in #194.
michaelklishin
force-pushed
the
rabbitmq-objc-client-194-take-2
branch
from
3ba2990
to
95635f3
Compare
|
#197 includes fewer weak references and passes all tests. |
|
We can incrementally add to #197 and re-run @BarryDuggan's allocation tests on one hand, and integration tests on the other. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for some important dependencies of allocated channels and
RMQConnection itself.
In this client, RMQConnection auto-allocates a channel for
the purpose of special "channel zero" (system communication
in the protocol) purposes, and that leads to a loop
of strong references that prevent RMQConnection instances
from being released.
Contributed by @BarryDuggan in #194.