Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider making 'rabbitmqctl stop_app' output message more precise #1043

Closed
Ayanda-D opened this issue Nov 29, 2016 · 5 comments
Closed

Consider making 'rabbitmqctl stop_app' output message more precise #1043

Ayanda-D opened this issue Nov 29, 2016 · 5 comments
Assignees
Milestone

Comments

@Ayanda-D
Copy link
Contributor

Something small here (unless done on purpose?); currently, output message of rabbitmqctl stop_app;

Stopping node 'rabbit@host' ...

In true essence, the node is still running, and we just stopped the application. The following should be more precise;

Stopping rabbit application on node 'rabbit@host' ...

I guess the same applies to rabbitmq-cli.

@michaelklishin
Copy link
Member

Most RabbitMQ users don't know the difference between stopping an Erlang application and an Erlang VM. So would it really be a net improvement?

@Ayanda-D
Copy link
Contributor Author

True. Usability wise from an non-Erlang perspective wouldn't seem like an improvement, but, it does give a true reflection of the current state of their instance. So it depends on what we're prioritising, users who might confuse this, or a true reflection of the server state.

@gerhard gerhard self-assigned this Dec 14, 2016
@gerhard gerhard added this to the 3.7.0 milestone Dec 14, 2016
@gerhard
Copy link
Contributor

gerhard commented Dec 14, 2016

@michaelklishin should this be implemented in 3.6.7 as well? I'm thinking yes.

gerhard added a commit that referenced this issue Dec 14, 2016
Already implemented in the new CLI, planned to ship as of 3.7.0

#1043
@michaelklishin
Copy link
Member

@gerhard sounds good.

gerhard added a commit that referenced this issue Dec 14, 2016
Already implemented in the new CLI, planned to ship as of 3.7.0

#1043
@gerhard
Copy link
Contributor

gerhard commented Dec 14, 2016

Implemented in both v3.6 and v3.7 CLI, making its way through the pipeline.

@michaelklishin michaelklishin modified the milestones: 3.6.7, 3.7.0 Dec 14, 2016
@gerhard gerhard closed this as completed Dec 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants