Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Queue argument check can produce a confusing error message #1887

Closed
lukebakken opened this issue Feb 17, 2019 · 0 comments
Closed

Queue argument check can produce a confusing error message #1887

lukebakken opened this issue Feb 17, 2019 · 0 comments
Assignees
@lukebakken
Labels
bug
Milestone
3.7.13

Comments

@lukebakken
Copy link
Collaborator

See streadway/amqp#373

Run the following to reproduce: repro.go.txt
@lukebakken lukebakken added the bug label Feb 17, 2019
@lukebakken lukebakken self-assigned this Feb 17, 2019
@lukebakken lukebakken mentioned this issue Feb 17, 2019
Closed
lukebakken added a commit that referenced this issue Feb 17, 2019
@lukebakken
Check exclusive owner before durable argument
8da757c 
Fixes #1887
@lukebakken lukebakken mentioned this issue Feb 17, 2019
Merged
lukebakken added a commit that referenced this issue Feb 18, 2019
@lukebakken
Check exclusive owner before durable argument
4f853ad 
Fixes #1887
michaelklishin added a commit to ruby-amqp/bunny that referenced this issue Feb 18, 2019
@michaelklishin
More queue declaration property equivalence checks
e556e9d 
See streadway/amqp#373 and
rabbitmq/rabbitmq-server#1887 for background.
michaelklishin added a commit that referenced this issue Feb 18, 2019
@michaelklishin
Queue ownership check: provide more details in the messaage
be8658f 
See #1887 for context. When an exclusive queue is redeclared with
the exclusive property set to `false`, the code considers it to be
an ownership check. This is a leaked implementation detail that's
been around for years, so changing it might do more harm than good.

What we can do is provide a bit more information about when the
check might fail in the message.
@michaelklishin michaelklishin added this to the 3.7.13 milestone Feb 18, 2019
@michaelklishin michaelklishin changed the title Queue argument check can produce confusing results Queue argument check can produce a confusing error message Feb 18, 2019
kjnilsson pushed a commit that referenced this issue Feb 20, 2019
@lukebakken @kjnilsson
Check exclusive owner before durable argument
e8ab6ce 
Fixes #1887
kjnilsson pushed a commit that referenced this issue Feb 20, 2019
@michaelklishin @kjnilsson
Queue ownership check: provide more details in the messaage
2a57949 
See #1887 for context. When an exclusive queue is redeclared with
the exclusive property set to `false`, the code considers it to be
an ownership check. This is a leaked implementation detail that's
been around for years, so changing it might do more harm than good.

What we can do is provide a bit more information about when the
check might fail in the message.
kjnilsson pushed a commit that referenced this issue Feb 22, 2019
@lukebakken @kjnilsson
Check exclusive owner before durable argument
964bb21 
Fixes #1887
kjnilsson pushed a commit that referenced this issue Feb 22, 2019
@michaelklishin @kjnilsson
Queue ownership check: provide more details in the messaage
f7f8e4d 
See #1887 for context. When an exclusive queue is redeclared with
the exclusive property set to `false`, the code considers it to be
an ownership check. This is a leaked implementation detail that's
been around for years, so changing it might do more harm than good.

What we can do is provide a bit more information about when the
check might fail in the message.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lukebakken lukebakken

Labels
bug
Projects
None yet
Milestone
3.7.13
Development

No branches or pull requests
2 participants
@michaelklishin @lukebakken