Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing support for unsigned 32-bit integer field value type #20

Closed
TheCount opened this issue Sep 25, 2013 · 3 comments
Closed

Missing support for unsigned 32-bit integer field value type #20

TheCount opened this issue Sep 25, 2013 · 3 comments
Assignees
Milestone

Comments

@TheCount
Copy link

When sending a message with a header with value kind 'i' (meaning long-uint) as specified in AMQP 0-9-1 section 4.2.1, the rabbitmq-server responds with Connection.Close with an obscure "INTERNAL_ERROR". I haven't had the time to build a server and the management tool from the repositories right now, but the issue seems to be in rabbit_binary_parser.erl, lines 41 and onward, where the case for 'i' is simply missing.

@hairyhum
Copy link
Contributor

hairyhum commented Dec 3, 2015

There are bunch of types from 0-9-1 missing in rabbit_binary_parser. I'm not sure though what RType values should be used for them.
Missing types:
'B' short-short-uint
'U' short-int
'u' short-uint
'i' long-uint
'L' long-long-int

And there are also 's' type tag, which means 'short-string' which is OCTET *string-char and in current implementation it is being parsed like signed short
https://github.com/rabbitmq/rabbitmq-common/blob/master/src/rabbit_binary_parser.erl#L66

@michaelklishin
Copy link
Member

@hairyhum take a look at AMQP 0-9-1 Errata as well as AMQP 0-8 and 0-9-1 differences.

@hairyhum
Copy link
Contributor

hairyhum commented Dec 3, 2015

So we can at least add 'B', 'u', and 'i' types as 'unsignedbyte', 'unsignedshort' and 'unsignedint' respectively.

@hairyhum hairyhum closed this as completed Dec 4, 2015
dcorbacho pushed a commit that referenced this issue May 27, 2016
Respect authentication failure notification capability here
dcorbacho pushed a commit that referenced this issue Nov 18, 2020
dcorbacho pushed a commit that referenced this issue Jul 5, 2023
osiris_log: Update log format specification
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants