Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CTL_ERL_ARGS can't be set #2394

Closed
lukebakken opened this issue Jun 25, 2020 · 1 comment · Fixed by #2395
Closed

CTL_ERL_ARGS can't be set #2394

lukebakken opened this issue Jun 25, 2020 · 1 comment · Fixed by #2395
Assignees
@lukebakken
Labels
bug
Milestone
3.8.6

Comments

@lukebakken
Copy link
Collaborator

Reported here: https://groups.google.com/d/topic/rabbitmq-users/Ovp4iKNFL7Y/discussion

Broken by this commit:

68c3055

We may have to look at CTL_DIST_PORT_* settings as well.
@lukebakken lukebakken added the bug label Jun 25, 2020
@lukebakken lukebakken self-assigned this Jun 25, 2020
@lukebakken lukebakken added this to the 3.8.6 milestone Jun 25, 2020
lukebakken added a commit that referenced this issue Jun 25, 2020
@lukebakken
Re-enable CTL_ERL_ARGS and dist port settings
20762bd 
Fixes #2394
@lukebakken lukebakken mentioned this issue Jun 25, 2020
Merged
dumbbell added a commit that referenced this issue Jun 26, 2020
@dumbbell
scripts: Restore the RABBITMQ_CTL_* env. variables handling
07cf6f6 
$RABBITMQ_CTL_ERL_ARGS must be handled in the scripts because a user
can specify any erl(1) arguments.

$RABBITMQ_CTL_DIST_PORT_* could be and should be handled at runtime to
avoid code duplication between the Unix and Windows scripts. It could
also benefit from a few more checks (like MIN < MAX). But let's already
restore the feature.

Fixes #2394.
@dumbbell
Copy link
Member

Please ignore my commit referenced in this issue. I discovered you already prepared something after. I deleted my branch, yours looks good :-)

dumbbell pushed a commit that referenced this issue Jun 30, 2020
@lukebakken @dumbbell
Re-enable CTL_ERL_ARGS and dist port settings
eafa2aa 
Fixes #2394
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lukebakken lukebakken

Labels
bug
Projects
None yet
Milestone
3.8.6
Development

Successfully merging a pull request may close this issue.

Restore CTL_ERL_ARGS env variables rabbitmq/rabbitmq-server
2 participants
@dumbbell @lukebakken