Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return appropriate response when stream leader not available #3874

Closed
acogoluegnes opened this issue Dec 9, 2021 · 0 comments · Fixed by #3879
Closed

Return appropriate response when stream leader not available #3874

acogoluegnes opened this issue Dec 9, 2021 · 0 comments · Fixed by #3879
Assignees
@acogoluegnes
Labels
bug
Milestone
3.9.12

Comments

@acogoluegnes
Copy link
Contributor

rabbit_stream_manager:lookup_leader/2 function does not make the difference between a non-existing stream and a non-available leader. This leaks up to the client that may think the stream they want to interact with does not exist at all, whereas the leader may not be available yet, especially when the system is starting up.

Original discussion: #3873.
@acogoluegnes acogoluegnes added this to the 3.9.12 milestone Dec 9, 2021
@acogoluegnes acogoluegnes self-assigned this Dec 9, 2021
acogoluegnes added a commit that referenced this issue Dec 10, 2021
@acogoluegnes
Return appropriate response when stream leader not available
bd4771a 
Fixes #3874
@acogoluegnes acogoluegnes mentioned this issue Dec 10, 2021
Merged
acogoluegnes added a commit to rabbitmq/rabbitmq-stream-java-client that referenced this issue Dec 10, 2021
@acogoluegnes
Adapt "kill leader" command to new return type
67c1f36 
References rabbitmq/rabbitmq-server#3874
mergify bot pushed a commit that referenced this issue Dec 10, 2021
@acogoluegnes
Return appropriate response when stream leader not available
2455aec 
Fixes #3874

(cherry picked from commit bd4771a)

# Conflicts:
#	deps/rabbitmq_stream/src/rabbit_stream_manager.erl
#	deps/rabbitmq_stream/test/rabbit_stream_manager_SUITE.erl
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@acogoluegnes acogoluegnes

Labels
bug
Projects
None yet
Milestone
3.9.12
Development

Successfully merging a pull request may close this issue.

Return appropriate response when stream leader not available rabbitmq/rabbitmq-server
1 participant
@acogoluegnes