New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce per message disk overhead #10339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I assume we will document this "UNIX wizard"-ish format internally (that is, in the code) before shipping 3.13 :) |
kjnilsson
reviewed
Jan 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly a couple of questions and suggestions to discuss before we commit.
Message container annotation keys are stored on disk. By shortening them we save 95 - 58 = 37 bytes per message. ``` 1> byte_size(term_to_binary(#{exchange => <<>>, routing_keys => [<<"my-key">>], durable => true, priority => 3, timestamp => 1000})). 95 2> byte_size(term_to_binary(#{x => <<>>, rk => [<<"my-key">>], d => true, p => 3, ts => 1000})). 58 ``` This should somewhat reduce disk I/O and disk space.
Prevent key 'durable' with value 'undefined' being added to the mc annotations, for example when the durable field was not set, but another AMQP 1.0 header field was set.
kjnilsson
approved these changes
Jan 18, 2024
kjnilsson
approved these changes
Jan 18, 2024
michaelklishin
pushed a commit
that referenced
this pull request
Jan 31, 2024
* Reduce per message disk overhead Message container annotation keys are stored on disk. By shortening them we save 95 - 58 = 37 bytes per message. ``` 1> byte_size(term_to_binary(#{exchange => <<>>, routing_keys => [<<"my-key">>], durable => true, priority => 3, timestamp => 1000})). 95 2> byte_size(term_to_binary(#{x => <<>>, rk => [<<"my-key">>], d => true, p => 3, ts => 1000})). 58 ``` This should somewhat reduce disk I/O and disk space. * Ensure durable is a boolean Prevent key 'durable' with value 'undefined' being added to the mc annotations, for example when the durable field was not set, but another AMQP 1.0 header field was set. * Apply feedback
michaelklishin
pushed a commit
that referenced
this pull request
Feb 1, 2024
* Reduce per message disk overhead Message container annotation keys are stored on disk. By shortening them we save 95 - 58 = 37 bytes per message. ``` 1> byte_size(term_to_binary(#{exchange => <<>>, routing_keys => [<<"my-key">>], durable => true, priority => 3, timestamp => 1000})). 95 2> byte_size(term_to_binary(#{x => <<>>, rk => [<<"my-key">>], d => true, p => 3, ts => 1000})). 58 ``` This should somewhat reduce disk I/O and disk space. * Ensure durable is a boolean Prevent key 'durable' with value 'undefined' being added to the mc annotations, for example when the durable field was not set, but another AMQP 1.0 header field was set. * Apply feedback
michaelklishin
pushed a commit
that referenced
this pull request
Feb 29, 2024
* Reduce per message disk overhead Message container annotation keys are stored on disk. By shortening them we save 95 - 58 = 37 bytes per message. ``` 1> byte_size(term_to_binary(#{exchange => <<>>, routing_keys => [<<"my-key">>], durable => true, priority => 3, timestamp => 1000})). 95 2> byte_size(term_to_binary(#{x => <<>>, rk => [<<"my-key">>], d => true, p => 3, ts => 1000})). 58 ``` This should somewhat reduce disk I/O and disk space. * Ensure durable is a boolean Prevent key 'durable' with value 'undefined' being added to the mc annotations, for example when the durable field was not set, but another AMQP 1.0 header field was set. * Apply feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Message container annotation keys are stored on disk. By shortening them we save 95 - 58 = 37 bytes per message.
This should somewhat reduce disk I/O and disk space.