Make 'rabbitmqctl rename_cluster_node' and 'rabbitmqctl update_cluster_nodes ' no-ops #10369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelklishin
changed the title
michaelklishin
added a commit
to rabbitmq/rabbitmq-website
that referenced
this pull request
Jan 18, 2024
This makes a command that renames cluster members a no-op. This command is really complex under the hood and is fundamentally incompatible with a few key Raft-based features: * Khepri * Quorum queues * Streams Because Khepri first ships in RabbitMQ 3.13, now is the time to effectively eliminate this command. It will be permanently removed together with other deprecated CLI commands in 4.0. Per discussion with the team. Closes #10367.
michaelklishin
force-pushed
the
rabbitmq-server-10367
branch
from
55f2cad
to
2171b5a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes two commands that rename offline cluster members
no-ops. The commands are really complex under
the hood and are fundamentally incompatible
with a few key Raft-based features:
Because Khepri first ships in RabbitMQ 3.13,
now is the time to effectively eliminate both.
It will be permanently removed together with
other deprecated CLI commands in 4.0.
Per discussion with the team.
Some background
This command was originally introduces for the needs of the "1.0-ish" TAS (né PCF) RabbitMQ tile around 2015. Due to some BOSH templating changes, the tile could not keep the original node naming scheme and we had to introduce a way of renaming nodes during a cluster upgrade.
Needless to say, it is very complex and entirely Mnesia-specific.
It is not widely used and was never widely recommended in any RabbitMQ or TAS RabbitMQ tile docs.
Further comments
Closes #10367.