Single active consumer #1802
Merged
Single active consumer #1802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces exclusive consumer. A queue is declared with the x-exclusive-consumer argument set to true and it will dispatch messages to only one consumer at a time. This exclusive consumer is typically the first one to consume from the queue. Other consumers are simply ignored. If the exclusive consumer is cancelled, another consumer is picked up randomly. Subsequent commits will handle other cases than simple cancellation (e.g. the owning channel of the exclusive consumer is closed). [#161090309] References #1743
[#161090309] References #1743
[#161090309] References #1743
Instead of x-exclusive-consumer. [#161090309] References #1743
Conflicts: src/rabbit_amqqueue.erl src/rabbit_amqqueue_process.erl
Single active consumer will have its own info item. [#161090309] References #1743
Uses a buffer list for non-active consumers. The active consumer is stored in the usual consumers structure, so the logic around servicing consumers is kept the same. [#162582065] Fixes #1799
…r-in-qq Conflicts: src/rabbit_fifo.erl src/rabbit_quorum_queue.erl
michaelklishin
changed the title
…r-in-qq Conflicts: src/rabbit_quorum_queue.erl
kjnilsson
requested changes
Jan 7, 2019
src/rabbit_fifo.erl
Outdated
| S = return_all(State0, Checked0), | ||
| Effects = cancel_consumer_effects(ConsumerId, S, Effects0), | ||
| {Effects, #state{waiting_consumers = WaitingConsumers1}}; | ||
| false -> |
There was a problem hiding this comment.
The prior function clause when it matches on the empty list should make this clause impossible.
michaelklishin
approved these changes
Jan 8, 2019
michaelklishin
deleted the
rabbitmq-server-1799-single-active-consumer-in-qq
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1799, supersedes #1744.
Depends on rabbitmq/rabbitmq-common#288.