Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle and raise protocol error for absent queues assumed to be alive #2233

Merged
merged 1 commit into from Feb 9, 2020
Merged

Handle and raise protocol error for absent queues assumed to be alive #2233

merged 1 commit into from Feb 9, 2020

Conversation

Ayanda-D
Copy link
Contributor

@Ayanda-D Ayanda-D commented Feb 7, 2020

Proposed Changes

Hey guys, I think this was supposed to be part of #1685. An E({absent, Q, alive}); was introduced, but the appropriate handling in the error handler fun E, was not implemented.

This is priv_absent\4 in master & v3.8.x, and rabbit_misc:absent\2 in v3.7.x.
Opening a separate PR for v3.7.x

Types of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes issue #NNNN)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause an observable behavior change in existing systems)
  • Documentation improvements (corrections, new content, etc)
  • Cosmetic change (whitespace, formatting, etc)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating
the PR. If you're unsure about any of them, don't hesitate to ask on the
mailing list. We're here to help! This is simply a reminder of what we are
going to look for before merging your code.

  • I have read the CONTRIBUTING.md document
  • I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
  • All tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in related repositories

Further Comments

If this is a relatively large or complex change, kick off the discussion by
explaining why you chose the solution you did and what alternatives you
considered, etc.

@michaelklishin michaelklishin merged commit 8b9b87c into rabbitmq:master Feb 9, 2020
michaelklishin added a commit that referenced this pull request Feb 9, 2020
Handle and raise protocol error for absent queues assumed to be alive

(cherry picked from commit 8b9b87c)
@michaelklishin michaelklishin added this to the 3.8.3 milestone Feb 9, 2020
@michaelklishin
Copy link
Member

Backported to v3.8.x.

@Ayanda-D Ayanda-D deleted the handle-absent-alive-queues branch February 9, 2020 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants